Question: support pause reconciliation for vmcluster cr

VictoriaMetrics / operator

Kubernetes operator for Victoria Metrics

Apache License 2.0

406 stars 142 forks source link

Question: support pause reconciliation for vmcluster cr #943

Closed just1900 closed 2 months ago

just1900 commented 2 months ago

Consider adding support for pause reconciliation for vmcluster cr, similar to what have been done in vmalertmanager https://github.com/VictoriaMetrics/operator/blob/8f025b3b4fce6e3472cabaa49b07c748aa6e3ffa/api/victoriametrics/v1beta1/vmalertmanager_types.go#L151

This feature would be helpful when performing operational tasks. I am willing to submit a pull request if you are open to merging this change. @f41gh7

Haleygo commented 2 months ago

Sounds like a good feature to all the components. But I don't see any related implementation for VMAlertmanagerSpec.Paused now, seems like a unfinished TODO. wdyt? @f41gh7

f41gh7 commented 2 months ago

Looks valuable feature to me. And good catch, currently Paused option is no-op for alertmanager.

f41gh7 commented 2 months ago

Changes included to the v0.44.0 release