controllers: use client.Patch for finalizers mutations instead of Update

VictoriaMetrics / operator

Kubernetes operator for Victoria Metrics

Apache License 2.0

406 stars 142 forks source link

controllers: use client.Patch for finalizers mutations instead of Update #950

Closed f41gh7 closed 2 months ago

f41gh7 commented 2 months ago

It must possible issues with JSON marshalling mutations and remove default values setting for CRD object.

Previously, it was possible, that object was modified during unmarshalling, it causes object mutation after client.Update call. Since object state wasn't restored to the original version after marshalling.

https://github.com/VictoriaMetrics/operator/issues/946