VictoriaMetrics / victorialogs-datasource

Grafana datasource for VictoriaLogs
Apache License 2.0
81 stars 2 forks source link

Ignore issue (was: Grafana API datasource health check returns 400) #84

Closed eserte closed 1 day ago

eserte commented 4 days ago

When using the grafana API datasource health check against a datasource using the victoriametrics-datasource plugin, e.g. using /api/datasources/uid/abcdefghijklmn/health then it fails with a 400 status and a JSON body

{"message":"got response code 400","status":"ERROR"}

The datasource is configured with the URL http://vmselect-aggregator-clusterip.vm-output.svc.cluster.local:8481/select/1234/prometheus (note the multitenant setup) and otherwise works fine, only the above health check does not work.

If I understand the source code correctly, then the health check is done in this function https://github.com/VictoriaMetrics/victorialogs-datasource/blob/518eca5756fbab962a54f42420e0326dd7f3a6c0/pkg/plugin/datasource.go#L146 The /health part is just added to the configured URL, so the result would be http://vmselect-aggregator-clusterip.vm-output.svc.cluster.local:8481/select/1234/prometheus/health which does not work (i.e. fails with a 400, which is then propagated).

eserte commented 4 days ago

Sorry, wrong project...