VictoriaRoux / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #294

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: user-dashboard

Link to the relevant commit(s):
1. 
https://code.google.com/p/oppia/source/detail?r=d5ecb20d17e401b81614ef0c87e90bbb
86bce0de&name=user-dashboard
2. 
https://code.google.com/p/oppia/source/detail?r=e30e73b5eb7fd51522dcdc73aa1accfb
eb132dfd&name=user-dashboard

Purpose of code changes on this branch: Add a new user dashboard page that 
contains information about an editor's explorations. Later on, this page will 
also contain information about things like recent updates to explorations, 
recent comments and feedback threads, and so on.

When reviewing my code changes, please focus on: code clarity and correctness. 
Also, in your opinion, is the current UI sufficient for merging into develop 
and shipping in a release, even if we don't get to do further work on it before 
that?

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by s...@seanlip.org on 2 Aug 2014 at 5:46

GoogleCodeExporter commented 9 years ago
Didn't look much details as big chunk of changes all seem to be just moving 
code around.
Ya I think it's ok to have this pushed to public although I do see the 
dashboard page can use some pretty up. Again I think it's ok tho -- as the 
first time visitors don't see it and for logged in users it's more useful to 
have the dashboard as default even in the current state imho.

Original comment by kash...@google.com on 5 Aug 2014 at 5:43

GoogleCodeExporter commented 9 years ago

Original comment by s...@seanlip.org on 6 Aug 2014 at 6:37