search

Victorian-Bioinformatics-Consortium / degust

Deprecated : Use https://github.com/drpowell/degust
GNU General Public License v3.0
44 stars 15 forks source link

Propagating fdrThreshold and fcThreshold settings to UI #50

Closed andrewjrobinson closed 7 years ago

andrewjrobinson commented 7 years ago

I modified Settings.hs so that it would take fdrThreshold and fcThreshold from the user settings and pass them through to the UI (which already had support for them). I have never used Haskell before so please check my changes make sense and didn't break something else.

drpowell commented 7 years ago

Thanks Andrew. I've deprecated this branch. Backend rewrite is now here : https://github.com/drpowell/degust

Is your idea with this that you can start a session with a configured fdr & fc threshold?

andrewjrobinson commented 7 years ago

Is your idea with this that you can start a session with a configured fdr & fc threshold?

Yes, exactly what we wanted; I saw you already had all the ui code to respond to the values in the configuration. We are using degust embedded within another application (which creates the files/config) hence why I only added the config to backend code and didn't get around to adding it to the configure interface.

FYI, the other application is our RNAseq database which will be used to present LTU's rnaseq data to the world. It combines Degust and eFP Browser to allow researchers to view dataset's prior to downloading them. I will be demo'ing it at VLSCI in the coming weeks if you are interested (date to be determined).

I've deprecated this branch. Backend rewrite is now here : https://github.com/drpowell/degust

Yes, I saw it after submitting pull request. The old one is currently embedded in our application so will stick with it for now since our project is almost complete but will look at migrating to the new version.