VidYen / VidYen-WordPress-Plugins

VidYen Plugins for WordPress
GNU General Public License v2.0
9 stars 2 forks source link

Moving AS and CH to base #31

Closed VidYen closed 6 years ago

VidYen commented 6 years ago

I thought this over and I feel like if AS and CH don't change much, then they should go into the base.

That said...

  1. Coinhive would need to go pure shortcode and not need a table.
  2. It should have a subpage and a disclaimer that if you use this code without consent it is a hostile action against your users.
  3. I'm going to default the API keys to the test server if no keys were set in shortcode
  4. But since I'm not that unethical, I'm going to return a line of text in the simple miner that says, you forgot to put in a attribute for your api keys (this is mostly for myself so I remember to input my API keys)
  5. Adscend is already pure shortcode so won't need to drop the tables
  6. I could in theory throw the WooWallet shortcode

My main reluctance is that all three of those rely on 3rd party plugins which may disapear one day. But I suppose it won't kill the base and the site admins can just remove the shortcodes and we can find alternatives down the road.

VidYen commented 6 years ago

Determined better to keep AS and CH seperate.