implementation should be implements - Githubissues

VidocqH / lsp-lens.nvim

Neovim plugin for displaying references and difinition infos upon functions like JB's IDEA.

MIT License

252 stars 15 forks source link

implementation should be implements #5

Closed xiantang closed 1 year ago

xiantang commented 1 year ago

xxxxManager is a struct and it implements Manager interface. so lsp-lens should display Implements:1 | References: 5

xiantang commented 1 year ago

in lspsaga it is also shown as "Implements" and not as "Implementation", I think we have to adapt to lspsaga

VidocqH commented 1 year ago

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'. 哈哈哈哈哈哈哈哈😂

xiantang commented 1 year ago

谢谢你

xiantang commented 1 year ago

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'. 哈哈哈哈哈哈哈哈😂

I'm willing to contribute the PR

VidocqH commented 1 year ago

OK, that will be an easy work. I use "implementation" because of the request method 'textDocument/implementation'. 哈哈哈哈哈哈哈哈😂

I'm willing to contribute the PR

Oh.. I already written it...

xiantang commented 1 year ago

ok coool

xiantang commented 1 year ago

let me try

xiantang commented 1 year ago

Looks good