search

Vidvox / oscqueryhtml

MIT License
14 stars 1 forks source link

test cases that throw javascript exceptions #25

Closed mrRay closed 6 years ago

mrRay commented 6 years ago

if you load either of the attached docs into the test server, the resulting JSON causes the html page to throw the following exception:

bundle.js?HTML:8 Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
    at b (bundle.js?HTML:8)
    at t (bundle.js?HTML:8)
    at t (bundle.js?HTML:8)
    at t (bundle.js?HTML:8)
    at w (bundle.js?HTML:8)
    at i.retrieveJson.t (bundle.js?HTML:8)
    at bundle.js?HTML:1

...to be clear, the JSON that's throwing an exception is unquestionably malformed and doesn't meet the minimum requirements of the spec. all the same, if you could please modify the js so it doesn't throw an exception for these and similar cases, and instead either silently ignores the invalid node or logs the error to the js console while rendering the rest of the valid json, that would be very nice!

oscqueryhtml_exception_01.txt oscqueryhtml_exception_02.txt

dustmop commented 6 years ago

Erroneous nodes like these now produce messages in the html, instead of throwing errors, thanks to commit 0c4f3304db7344. Also, started using mocha to run unit tests, which will make future changes easier.