default toggle value being sent is inverted

Vidvox / oscqueryhtml

MIT License

14 stars 1 forks source link

default toggle value being sent is inverted #52

Closed mrRay closed 6 years ago

mrRay commented 6 years ago

steps to reproduce:

launch 0.4.2.4 of the crappy little test server, open the included .json file ("DefaultToggleValueInverted.json")
click the link that opens the HTML UI in a browser window
click on the first toggle, and compare the message received by the crappy little test server to the values of the toggles in the UI
video: https://www.vidvox.net/rays_oddsnends/18.08.29-Layer%201-12.30.36.mov

DefaultToggleValueInverted.json.zip

dustmop commented 6 years ago

Hadn't thought about multiple controls in a single node, that is definitely broken. But a related question that I wasn't sure about, when a toggle button is clicked to invert it's value, should the sent OSC message be the old value or the new value that the toggle is set to?

There's also a second bug here, that the echo'd OSC message is resetting the old value of the toggle. I can fix that as well.

dustmop commented 6 years ago

Oh wait, nevermind about the second bug, you already filed #51 about that.

dustmop commented 6 years ago

Fixed by ffef529.