search

Vidvox / oscqueryhtml

MIT License
14 stars 1 forks source link

setToggle buttons do not react on values from applyOSCMessageValue #62

Open SolfaMode opened 2 years ago

SolfaMode commented 2 years ago

When the OSC Query Server sends an update on a bool address, the new value is not reflected in the UI. index.js applyOSCMessageValue setter.value == 'setToggle' controls.js runSetter case type == 'setToggle' is empty.

Can be fixed by putting the following into controls.js. But I am not aware if this has any bad impact on other code.

} else if (type == 'setToggle') {
    // Reflect bool value from applyOSCMessageValue.
    let buttonElem = controlElem.querySelector('input');
    if (value === false || value == 'false') {
        value = 'false';
        isEnabled = false;
    } else {
        value = 'true';
        isEnabled = true;
    }
    buttonElem.value = value;
    if (isEnabled) {
        buttonElem.classList.add('enabled');
    } else {
        buttonElem.classList.remove('enabled');
    }
}

oscqueryhtml is a really nice UI for testing OSC Query Server. Thank You!