search

ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.
https://www.vienna-rss.com
Apache License 2.0
1.85k stars 227 forks source link

Add "Empty trash…" context menu to the Trash item #1453

Open nathanlesage opened 3 years ago

nathanlesage commented 3 years ago

It would be great if the Trash item would offer an "Empty trash…"-entry in its context menu which offers the same functionality as the corresponding menu item. I always first right-click the Trash item until I realise that this item is not there, and then I switch either to the app menu, or press the corresponding shortcut.

Having this item there in the context menu would be great.

Maybe, once could also remove the other items instead of deactivating them (it seems the same context menu is being reused by both collections and the Trash) while at it …?

Thank you for such a great piece of software!

Eitot commented 2 years ago

I'd prefer you completely reverse 03a507c6df17bbfd463b47271a336125fae79b82.

Having this Empty Trash command for all folders is contrary to the goal of a contextual menu.

Originally posted by @barijaona in https://github.com/ViennaRSS/vienna-rss/issues/1561#issuecomment-1133933246

I think it is worthwhile having an empty bin action there. The current menu is not particularly contextual. For example, selecting the bin folder has nearly every item disabled and the single-target actions (edit, rename, get info, etc.) still work when multiple feeds/folders are selected (but to which feed is it applied?). This menu needs to be refactored so that it works contextually. I will revisit this once the view-based table is implemented.

github-actions[bot] commented 1 year ago

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.

github-actions[bot] commented 6 months ago

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.