search

ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.
https://www.vienna-rss.com
Apache License 2.0
1.85k stars 227 forks source link

Support for Reader View #1628

Open robigan opened 2 years ago

robigan commented 2 years ago

Is your feature request related to a problem? Please describe. Possible implementation of the Reader View feature in Safari also inside of the Vienna integrated browser

Describe the solution you would like I would like to have a button I can quickly toggle when reading through my RSS articles when using the "Load Full HTML" feature so that I can read the website using a stripped down, easier to read web-page.

Describe alternatives you have considered This might need reverse engineering if Apple doesn't provide this in WebKit. Opening in Safari breaks the experience of reading inside of Vienna

Additional context https://developer.apple.com/forums/thread/92673 May be helpful. If this has already been implemented then I am stupid

Eitot commented 1 year ago

It does not appear that the reader is a feature of WebKit, probably only Safari. SFSafariViewController (what the thread you linked to is about) is available is Safari view that developers can use in their apps instead of WebKit. It is only available to iOS though.

Vienna sort of supports this by going to the Folder menu and switching between "Use Current Style for Articles" and "Use Web Page for Articles" (you could assign your own keyboard shortcuts), but this will change the setting for the folder as a whole.

I will leave this open as a feature request to perhaps allow for an ad-hoc toggle to view the current article in one of Vienna's styles without changing the setting for the folder.

robigan commented 1 year ago

It does not appear that the reader is a feature of WebKit, probably only Safari. SFSafariViewController (what the thread you linked to is about) is available is Safari view that developers can use in their apps instead of WebKit. It is only available to iOS though.

Vienna sort of supports this by going to the Folder menu and switching between "Use Current Style for Articles" and "Use Web Page for Articles" (you could assign your own keyboard shortcuts), but this will change the setting for the folder as a whole.

I will leave this open as a feature request to perhaps allow for an ad-hoc toggle to view the current article in one of Vienna's styles without changing the setting for the folder.

So somehow I missed this, but I was looking at Reader 5's features and they seem to have implemented this. It didn't mention it only being on iOS that feature so who knows

Eitot commented 1 year ago

Reeder 5 for Mac does not have the Safari reader. It does use the term "reader view" for a custom implementation.

robigan commented 1 year ago

I see

github-actions[bot] commented 11 months ago

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.