search

ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.
https://www.vienna-rss.com
Apache License 2.0
1.85k stars 227 forks source link

Crash upon deleting feed #1711

Open Limfjorden opened 1 year ago

Limfjorden commented 1 year ago

Describe the bug Vienna crashed after deleting a feed.

To Reproduce

  1. I added a new feed, the URL of my Lemmy notification inbox.

  2. I see that the feed does not work

  3. I delete the feed

  4. Vienna crashes

  5. When I open Viena again, the feed is deleted.

Screenshots Add screenshots to help explain your problem, if possible.

Please complete the following information:

Additional information: Here is the log: https://pastebin.com/gTF6s5CA

Eitot commented 1 year ago

The crash report unfortunately does not give a lot of information to find the cause of the crash. It seems to have something to do with the sidebar (NSOutlineView) and its textDidEndEditing: method. Notifications (NSNotification) are involved as well. Perhaps the text field of the feed item in the sidebar was in "edit mode" while it was deleted?

I am not sure if it is worthwhile diagnosing this further, as significant changes have been made to the sidebar code in 3.9.0 (a beta is available). The textDidEndEditing: method, for example, is no longer used.

github-actions[bot] commented 1 week ago

This issue hasn't been updated in a while so we're going to mark it as stale. stale issues will automatically be closed after 60 days of inactivity. If this issue is still affecting you, please update us on how it affects you, and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. Thank you for your contributions.