ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.
https://www.vienna-rss.com
Apache License 2.0
1.85k stars 227 forks source link

Misbehaviors in 3.9.0 :7ad9df044: (8175) #1722

Closed macsrwe closed 3 months ago

macsrwe commented 10 months ago

Just installed this release onto macOS Monterey 12.7.2.

Upon launch, main window immediately snapped to entire width of screen, and left column snapped to minimum width; neither would respond to any corrective drag attempts, though cursor changed appropriately.

Relaunching seemed to clear this problem up... but shortly after, window snapped into the same state. Furthermore, typing into input fields in posted articles exhibited a further failure -- after typing a single character, input field grayed out and focus was shifted to the search bar. Typing a return character into an input field grayed out the field and opened the article in an external browser.

barijaona commented 10 months ago

To help us sort out the issue, can you quit Vienna, put aside its Preferences file (~/Library/Preferences/uk.co.opencommunity.vienna2.plist) and relaunch the app afterwards ?

macsrwe commented 10 months ago

OK... I did this, relaunched, it came up looking good in horizontal view with the bottom (article contents) pane closed. I lifted up the pane divider until it was half and half (which is how I usually use it). Then I selected a newsgroup, and an article line in that newsgroup. Bam, the window immediately readjusted itself to full width and minimum left-hand column, immediately as it displayed the article in the bottom pane.

Eitot commented 10 months ago

Does this happen with every feed or just particular ones? If so, can you post the feed URLs?

barijaona commented 10 months ago

Do you also see a problem similar to #1595 and #1622 : the width of the pane displaying the folder list changes after quitting and relaunching Vienna?

macsrwe commented 10 months ago

I can't tell if it happens with "every" feed, but it's happened with more than one.

I launched it fresh and bopped around a bit... it took me under 30 seconds to make it happen. That particular feed was https://feeds.feedburner.com/LegalInsurrection and the article was third from last at this moment: "The Los Angles Times Announces Significant Employee Layoffs."

As to @barijaona 's question, those bugs seem to involve the LH column size changing at launch time. In my case, the LH column is something reasonable at launch time, but slams itself to the minimum size upon choosing some article and then cannot be resized in any fashion short of quitting the app, nor can the window width be reduced to less than the new width, which is slightly more than full screen width (it can be expanded though).

It may be significant that I read most of my feeds in "Use Web Page for Articles" mode, and all the misbehavior has occurred so far with one of those feeds. It's exactly as if the app makes a computation when rendering the webpage image that it needs more than the available pane space to display it, and slams the window wide open and the LH column to minimum in an attempt to claim that much space. Just for kicks, after Vienna slammed the window wide open, I tried choosing a different feed that was not in web page mode, to see if the resizing controls would work again, but they didn't. Once they have been set wide, they're stuck until I quit the app.

Eitot commented 10 months ago

I did manage to trigger it now with https://feeds.feedburner.com/LegalInsurrection and "Use Web Page for Articles" enabled. It seems to be a problem with the web view.

Eitot commented 10 months ago

It seems that WKWebView will increase its size to fit the web content (instead of using horizontal scrolling if it does not fit). The WKWebView will expand beyond the size of its split-view area (causing the sidebar to be squished), so much that it even expands the window size (even beyond the display area).

macsrwe commented 10 months ago

Sounds good.

Don't forget there's a second bug reported here that seems to have dropped through the cracks. Using https://waronguns.com/feed/, open any posting and type stuff in the comment box to see the misbehavior. Typing slowly may not trigger it, typing quickly will show it right up.

barijaona commented 10 months ago

Using https://waronguns.com/feed/, open any posting and type stuff in the comment box to see the misbehavior.

This one is due to the fact that what the user types is intercepted by Vienna before being sent to the web view. If I type "m" in the comment box, the article gets flagged / unflagged 😆

barijaona commented 4 months ago

@macsrwe Have you installed Vienna 3.9.1 ? Any comment on its behavior regarding these issues ?

macsrwe commented 4 months ago

Ha! Yes, I got suckered in by the "update available" announcement and absent-mindedly updated it. Started it up and immediately my left hand column shrank to its minimum width and could not be widened. Immediately I recalled that I was not updating Vienna (and why), and reinstalled the safe version I keep in Downloads. I didn't even bother to test the other objectionable behavior, i.e., the lost focus and the interpretation of field input as Vienna shortcut commands.

barijaona commented 4 months ago

I could not reproduce the issue with https://feeds.feedburner.com/LegalInsurrection Are you still running Monterey ? Can you point me to a recent article presenting the issue ?

Eitot commented 4 months ago

@barijaona The issue only happens when the webpage view of the article is enabled.

A while back I did some testing and tweaking, but was unable to resolve the issue. What I found is that this only seems to happen with the "horizontal" article view (article list on top, article view at the bottom).

Note that this code here is involved, but not the cause. Removing it does not fix the problem. https://github.com/ViennaRSS/vienna-rss/blob/a82691eb688e7d8a3b2db6b442583b4e0d5b702a/Vienna/Sources/Main%20window/ArticleListView.m#L174-L190

Another observation: when switching to vertical layout, then fixing the window and column sizes and then switching back to horizontal layout, the issue is not reproducible for me anymore.

barijaona commented 3 months ago

Closed with 3.9.2