Bug in Vienna 3.9.0 - Open links in external browser

ViennaRSS / vienna-rss

Vienna is a free and open-source RSS/Atom newsreader for macOS.

https://www.vienna-rss.com

Apache License 2.0

1.85k stars 227 forks source link

Bug in Vienna 3.9.0 - Open links in external browser #1728

Closed b0gdanw closed 4 months ago

b0gdanw commented 10 months ago

Clicking on a link in the internal browser that opens in the external browser, disables up-down keys navigation in the Headlines section. In Vienna 3.8.8 I can click on the title of an article or on any link in the internal browser, it opens in the background in the external browser (Safari) and I can continue using the up-down keys to go to the previous or next headline.

Vienna version 3.9.0
OS version: macOS 12.7.3

Eitot commented 10 months ago

I can confirm that the behaviour has changed. However, this only worked in 3.8.8 with the old WebKit browser (which was still used by default). Opting into the new browser results in the same behaviour as 3.9.0. It seems that the new WebKit browser claims and then returns the focus from and to the article list when clicking on a link. Clicking anywhere else in the browser won't have this behaviour.

barijaona commented 4 months ago

Will need to investigate this:

opening a link through one of the contextual menu items will keep the focus to the article list ;
opening a link with a direct click will make the article list lose the focus.

barijaona commented 4 months ago

The 3.8.8 version had code which returned first responser responsibility to the article list.

Will probably have to implement an equivalent through WebKitArticleView's WKNavigationDelegate Any advice, @Eitot or @TAKeanice ?

barijaona commented 4 months ago

Fixed in 3.9.1