search

ViewBlock / binance-api-node

:chart: A complete and heavily tested wrapper with typings for the Binance API.
669 stars 504 forks source link

futuresCancelBatchOrders lacks return-type annotation #641

Open bennycode opened 1 year ago

bennycode commented 1 year ago

The PR https://github.com/ViewBlock/binance-api-node/pull/586 introduced type definitions for futuresCancelBatchOrders. 🚀

Unfortunately, the function is missing a return-type definition which becomes a problem when trying to use it with strictly typed code:

binance-api-node/index.d.ts:666:5 - error TS7010: 'futuresCancelBatchOrders', which lacks return-type annotation, implicitly has an 'any' return type.

@jinusean do you know what the function returns or is it just Promise<void>?

P.S. It's funny that the error occurs in line 666. 😈

uslualper commented 1 year ago

How did you solve this problem? What is the best temporary way?

bennycode commented 1 year ago

How did you solve this problem? What is the best temporary way?

I downgraded to binance-api-node v0.12.6 - Does it work for you as well?

balthazar commented 1 year ago

I can probably revert the PR if @bennycode confirms, not a type expert