search

ViewComponent / demo

Rails application with ViewComponent
MIT License
157 stars 15 forks source link

use standard Rails rendering #12

Closed tomasc closed 5 years ago

tomasc commented 5 years ago

An update of the ActionView::Component to use standard Rails template rendering.

This is still work in progress, the main issue at the moment is evaluating blocks in the proper context of the parent component. Help wanted.

tomasc commented 5 years ago

PS would be good to wire this to Travis, so that it is clear that tests on this PR fail atm.

joelhawksley commented 5 years ago

Thank you for the PR! I am traveling now but will have a look next week ❤️

tomasc commented 5 years ago

Hi @joelhawksley please let me know whenever you have a moment. Would be great to wrap this PR up – but I think I need a bit of help here :-). Thanks!

tomasc commented 5 years ago

@joelhawksley Sure, I am up for it. Just let me know.

The main issue with the test suite is preserving the context of the parent component throughout the rendered block.

joelhawksley commented 5 years ago

@tomasc of course! I'll email you at your email address listed on your profile.

tomasc commented 5 years ago

closing in favor of #18