search

ViewComponent / view_component

A framework for building reusable, testable & encapsulated view components in Ruby on Rails.
https://viewcomponent.org
MIT License
3.19k stars 411 forks source link

Preparing for the next minor Ruby version #2033

Open boardfish opened 1 month ago

boardfish commented 1 month ago

It seems as though the next Ruby version will default to string literals being frozen. The linked gist outlines some things we can add to CI to make sure we're not falling foul of this.

Depending on whether there are any violations or not, we could enforce it strictly or add it as a test matrix option that we don't require in order for CI to pass. Happy to pick this up myself in the near future.

reeganviljoen commented 1 month ago

@boardfish in #2030 I also noticed a tests that was failing because of mismatched regex/string encodings I wonder if this is a bug in ruby(no mention in https://bugs.ruby-lang.org/) or a breaking change, just thought its worth noting

boardfish commented 1 month ago

Interesting! Good to see that testing against Ruby head is proving itself useful already ✨

reeganviljoen commented 4 days ago

@boardfish I am seeing a lot of these warnings, what strategy do you think we should use to collect and diagnose which dependencies they are coming from