ViewTube / viewtube

▶️ ViewTube: The open source, privacy-conscious way to enjoy your favorite YouTube content. Docs: https://viewtube.wiki, Status: https://uptime.viewtube.io
https://viewtube.io
GNU Affero General Public License v3.0
1.3k stars 74 forks source link

New video player #2387

Open moisout opened 11 months ago

moisout commented 11 months ago

Features

wnhrt commented 5 months ago

If possible, mobile gestures for brightness and volume, like Android VLC or NewPipe, would be nice. When in fullscreen mode, they allow adjusting brightness by moving with one finger up and down on the left half of the screen, and volume doing the same on the right half.

Looking forward to the new player, looks very promising!

moisout commented 5 months ago

If possible, mobile gestures for brightness and volume, like Android VLC or NewPipe, would be nice. When in fullscreen mode, they allow adjusting brightness by moving with one finger up and down on the left half of the screen, and volume doing the same on the right half.

Looking forward to the new player, looks very promising!

Volume would be possible, but websites cannot adjust screen brightness unfortunately

Edit: added to the todo list

patricgruber commented 3 months ago

Just tried the code and have to say the new video player looks really good and and works way better for me (the quality selection is actually enforced). Great work so far, keep it up!

patricgruber commented 3 months ago

I have some ideas for the UX. I know it is a work in progress, but I wanted to share my thoughts. For the video and audio quality selection and the subtitle selection a dropdown could be sufficient. Then the popup window wouldn't need to be so big and have multiple collapsible panels, which would make the handling a bit easier. I really like the codecs toggle though!

For the speed settings currently there is a checkbox to change the input type in the same line with the actual speed setting. I think this could be split into two different settings/lines and the Show video speed as a list setting could be moved entirely to the global settings menu, so that the "local" playback settings are relevant for the current video only.

These things don't necessarily need to be implemented and also don't need to be implemented within this one pull request. These small details can be checked again and maybe implemented after the video player is finished.

Since this is a WIP you might have planned this anyway, just wanted to give my two cents. If you need help with some part or just want to offload something to someone else, I'd be happy to help!

Edit: fixed typos

n-ce commented 3 months ago
  • [ ] iOS Safari

Is it the duration bug? I'm working on my own project update and I'm having this issue.

moisout commented 3 months ago
  • [ ] iOS Safari

Is it the duration bug? I'm working on my own project update and I'm having this issue.

Playback in general is not working. I haven't heard of that bug tho.

ac1mx commented 3 months ago

I really love the new player, and the fact that it will enforce the quality setting, however the default "Auto" quality setting is somewhat annoying. I'd love to see a default quality setting sometime, if you're up for it! Love the project, and thank you for keeping it maintained!