Viima / jquery-comments

The Javascript library of choice for implementing commenting in your web app
http://viima.github.io/jquery-comments/
MIT License
293 stars 118 forks source link

pinging problems #105

Open danman1234 opened 7 years ago

danman1234 commented 7 years ago

WHen i put enablePinging: true , the problem begin.

I n the source i see:

if i disable enablePinging, then i get:

The last elemnt i have combined myself for emoticons. But that is totally removed after i enable ping.

I have added in jquery-comments.js on line 1911

content.html(this.getFormattedCommentContent(commentModel))**.emojioneArea()**;

only when i add: .emojioneArea() i get the error, since i just want images instead of only unicodes

How come and how to fix this?

UPDATE

the problem was in this line:

   var dataFetched = this.after(this.options.enablePinging ? 2 : 1, function() {
                self.dataFetched = true;
                self.render();
            });

i changed 2 : 1 to 1:1 but what does this exactly do? It remove the sibling element as i mentioned but i dont see how

nxhoang commented 7 years ago

Sr I'm not able to resolve your issue but could you share emotional plugin to me?