Viima / jquery-comments

The Javascript library of choice for implementing commenting in your web app
http://viima.github.io/jquery-comments/
MIT License
293 stars 118 forks source link

plugin ver 1.2 not working on safari version 11.1 #137

Closed dapidmini closed 6 years ago

dapidmini commented 6 years ago

I sent these parameters to the plugin:

$('#comments-container').comments({
  profilePictureURL: "/path/to/img1.jpg"
  currentUserId: "",
  enableHashtags: true,
  enablePinging: true, 
  timeFormatter: function(time) {
    return moment(time).
  },
  getComments: function(success, error) {
    setTimeout(function() {
      var myData = {};
      myData['type'] = "review";
      myData['post_id'] = "100";
      $.ajax({
        type: 'get',
        url: '/comment/get_comments',
        data: myData,
        dataType: 'json',
        success: function(res) {
      success(res);
        },
        error: function(err) {
          console.log(err.responseText);
          alert('Oops.. something went wrong. Please try again later.');
        }
      });
    }, 500);
  },
  postComment: function(data, success, error) {},
  putComment: function(data, success, error) {},
  deleteComment: function(data, success, error) {},
});

it works fine in mozilla, chrome, and old version of safari. but it doesn't work in safari starting from version 11.1 (2017 release). it only shows spinning gif in place of existing comments data.

jessenieminen commented 6 years ago

Hi, thanks for reporting the issue @dapidmini!

We can't seem to reproduce the issue with Safari version 11.1 with any of our implementations, which would lead me to believe that this is an issue with your implementation. If you are able to reproduce the issue in a public environment, we can take a further look at this, but until then, I'll close the issue.

Are there perhaps JavaScript errors in your developer console that could point you to the right direction?