search

Viincenttt / MollieApi

This project allows you to easily add the Mollie payment provider to your application.
MIT License
148 stars 85 forks source link

added paypal specific properties to MandateRequest #206

Closed markusdresch closed 3 years ago

markusdresch commented 3 years ago

should probably be organized into a concrete class, similar to PaymentRequests?

Viincenttt commented 3 years ago

Thanks for the pull request. I'm going to need to dive into the Mandate API for a bit, since I haven't used it in a while. I'll get back to you!

markusdresch commented 3 years ago

just a note, the second commit would be a breaking change for someone using the MandateModel for directdebit mandates.

Sippelberg commented 3 years ago

Hey, could this get published? could really use that paypalBillingAgreementId.

markusdresch commented 3 years ago

@Sippelberg as a workaround in the meantime, you can simply inherit a class from MandateRequest and add your required properties.

Sippelberg commented 3 years ago

Hey @markusdresch, thanks for the workaround!

Viincenttt commented 3 years ago

Sorry for taking so long. I completely forgot about this PR.

Viincenttt commented 3 years ago

This is now live in 2.1.0.4: https://github.com/Viincenttt/MollieApi/releases/tag/2.1.0.4

Thanks @markusdresch !

Kind regards, Vincent