search

Viincenttt / MollieApi

This project allows you to easily add the Mollie payment provider to your application.
MIT License
152 stars 85 forks source link

Missing configure.await in BaseMollieClient #231

Closed Bodewes closed 3 years ago

Bodewes commented 3 years ago

In the BaseMollieClient one async call of the SendHttpRequest is missing a configureAwait(false).

Location: https://github.com/Viincenttt/MollieApi/blob/e87b6323a3bd0cf4cbe800997bdf5bc352d22255/Mollie.Api/Client/BaseMollieClient.cs#L51

The other calls were fixed with the resolution of #163. This calls seems to have been missed.

I ran into a deadlock using a call that lists all mandates. (I know, I should use Async all the way, but that is just simply not possible in our huge code base at the moment).

Viincenttt commented 3 years ago

Hi @Bodewes ,

This bug has now been fixed. If you update to version 2.1.0.6 of the Mollie library, you should no longer encounter any issues :)

Kind regards, Vincent