search

Viincenttt / MollieApi

This project allows you to easily add the Mollie payment provider to your application.
MIT License
148 stars 85 forks source link

Creditcard failures are causing deserialization errors #253

Closed kristofytp closed 3 years ago

kristofytp commented 3 years ago

Not all possible creditcard payment failure reasons are available which is causing deserialization errors in our software:

image

Viincenttt commented 3 years ago

In an old version of the library, the failure reason used to be an enum, which could cause deserialization issues. However, since July 7 2020, it was changed to a string to avoid this exact situation. Could it be that you were using a very old version of the library?

https://github.com/Viincenttt/MollieApi/commit/b2d9e692c3e14c29ca52517a295c06f9c35302b1#diff-486eb8a916276f3f84743bcab4b7f133d0eae7c16b203ed9c1fce9d27a4d4946

Non the less, I accept your pull request since it's nice to have a full and complete list of possible failure reasons as constant strings in the library.

kristofytp commented 3 years ago

Ah yes we are still using an older version, good to know the deserialization errors don't happen anymore in newer versions, will update asap :-)

Viincenttt commented 3 years ago

Cool! No problem! Thanks for the PR :)