VikLiegostaiev / react-page-scroller

Simple React component for smoothy full-page scolling using CSS animations. React Page Scroller
https://github.com/VikLiegostaiev/react-page-scroller
MIT License
417 stars 84 forks source link

Moved react, react-dom, and react-rouger to be peerDependencies for use in projects #50

Closed quuu closed 4 years ago

quuu commented 4 years ago

Currently react, react-dom, and react-router-dom are listed as dependencies of this project.

Upon trying to install this package into an existing project and using it, errors are thrown because this package has its own version of react as a dependency.

Replication: npx create-react-app <project name>

npm install this package

npm ls react you will see 2 version of react, one for the base project and 1 from this package

Moving the dependencies to peerDependencies and devDependencies allows projects to use this package.

https://classic.yarnpkg.com/en/docs/dependency-types/

VikLiegostaiev commented 4 years ago

@quuu thanks for your PR!