Closed Tusharjoshi1703 closed 1 year ago
@Tusharjoshi1703 please attach screenshot and working video of your project here and add the title of your project in your README.md file. Then it is good to go!
I have attached all . Please have a look.
On Wed, 28 Jun, 2023, 20:28 Shubhi Singh, @.***> wrote:
@Tusharjoshi1703 https://github.com/Tusharjoshi1703 please attach screenshot and working video of your project here and add the title of your project in your README.md file. Then it is good to go!
— Reply to this email directly, view it on GitHub https://github.com/Vikash-8090-Yadav/Future.WebNet/pull/378#issuecomment-1611603449, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZJSIQ6I2TAJX2Y2G3B5WDXNRBBJANCNFSM6AAAAAAZXIAD7I . You are receiving this because you were mentioned.Message ID: @.***>
@Tusharjoshi1703 Attach the working video here also in the conversation section as per the guidelines of PR, you should have to give proof here also. Do the same with all the next prs that you will be going to open.
The working video of the project is
Okay ! I'll follow this from now on. I have attached it in the conversation.
On Wed, 28 Jun, 2023, 20:48 Shubhi Singh, @.***> wrote:
@Tusharjoshi1703 https://github.com/Tusharjoshi1703 Attach the working video here also in the conversation section as per the guidelines of PR, you should have to give proof here also. Do the same with all the next prs that you will be going to open.
— Reply to this email directly, view it on GitHub https://github.com/Vikash-8090-Yadav/Future.WebNet/pull/378#issuecomment-1611635190, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZJSIR4CO5OXMXELK33YOLXNRDKVANCNFSM6AAAAAAZXIAD7I . You are receiving this because you were mentioned.Message ID: @.***>
Great @Tusharjoshi1703 the pr will get merged soon after the PA reviewed it, till then keep working on other issues. Thank you for your contribution and keep learning !!
Is this the screen lagging in the video or something wrong with the code? @Tusharjoshi1703
Thanks @shubhisingh184 . Also thank you for guiding me well.
There was just a screen lag . Sorry for the inconvenience
No worries, if you face any problem, just ping me on discord. I'm glad to hear that from you. Keep learning !!
I have a doubt regarding my previous PR. My issues #234 and #235 got merged under single pr. So my score will be 1 or 2
On Wed, 28 Jun, 2023, 21:07 Shubhi Singh, @.***> wrote:
@.**** approved this pull request.
— Reply to this email directly, view it on GitHub https://github.com/Vikash-8090-Yadav/Future.WebNet/pull/378#pullrequestreview-1503424617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZJSISBHI35OCBI4NQQZYTXNRFTZANCNFSM6AAAAAAZXIAD7I . You are receiving this because you were mentioned.Message ID: @.***>
I have a doubt regarding my previous PR. My issues #234 and #235 got merged under single pr. So my score will be 1 or 2 … On Wed, 28 Jun, 2023, 21:07 Shubhi Singh, @.> wrote: @*.*** approved this pull request. — Reply to this email directly, view it on GitHub <#378 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZJSISBHI35OCBI4NQQZYTXNRFTZANCNFSM6AAAAAAZXIAD7I . You are receiving this because you were mentioned.Message ID: @.>
If both merge under 1 then It will be counted as single point. I would suggest to create different branch for the Diffrent issue. Hope it helps!
356 completed .Please have a look.