VikeLabs / courseup

An open-source website built to simplify the experience of searching courses and building timetables for the University of Victoria.

https://courseup.vikelabs.ca/

42 stars 28 forks source link

Fix registration and booklist page bugs, cleanup some UI #486

Closed keithradford closed 1 year ago

keithradford commented 1 year ago

Description

The registration and booklist pages were broken, completely crashing the browser. It appears to have something to do with the useTerm hook @logankuzyk added. It's a nice hook to have, so ideally whatever was breaking is fixed, but returning back to the original implementation is a good hotfix. I also made some minor UI changes to the course cards on the scheduler sidebar, feel free to veto.

Closes #XX

Screenshots

Before

Screen Shot 2023-06-21 at 11 16 52 AM

After

Screen Shot 2023-06-21 at 11 16 34 AM

Checklist

[ ] The code follows all style guidelines.
[ ] The code passes all required tests.
[ ] The code is documented.
[ ] The code includes tests.
[ ] I have self-reviewed my changes and have done QA.

General Comments

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
courseup	❌ Failed (Inspect)		Jun 21, 2023 6:13pm

JoshoTheMosho commented 1 year ago

Thanks for the hotfix also the changes make a lot of sense for the course cards, LGTM