VikeLabs / courseup

An open-source website built to simplify the experience of searching courses and building timetables for the University of Victoria.
https://courseup.vikelabs.ca/
41 stars 29 forks source link

sort search results #506

Open zakariyavkhan opened 8 months ago

zakariyavkhan commented 8 months ago

Description

Sort the course search results by subject and course number.

Closes #505

Screenshots

Before

Screenshot 2023-10-31 at 19-08-18 CourseUp

After

Screenshot 2023-10-31 at 19-10-28 CourseUp

Checklist

General Comments

vercel[bot] commented 8 months ago

@zakariyavkhan is attempting to deploy a commit to the VikeLabs Team on Vercel.

A member of the Team first needs to authorize it.

aomi commented 7 months ago

I think to do this feature well, it will need to be considered carefully. Right now the search is all handled by Algolia with some minor tweaks to make it easier to use.

I can think of some situations where this breaks. Since this is anything search, if there's results that are for different subjects it will mess with them. If you are searching for a course within the same subject it messes with the order.

I would consider only engaging this sorting behaviour when there's explicit conditions met like the user is searching for just the subject. Just my two cents. Search is hard :|