search

VikeLabs / courseup

An open-source website built to simplify the experience of searching courses and building timetables for the University of Victoria.
https://courseup.vikelabs.ca/
41 stars 29 forks source link

Bug: Unsupported characters causing incorrect building names #508

Open JC-02 opened 6 months ago

JC-02 commented 6 months ago

Describe the Bug/Issue

Any classes in the new Sŋéqə ʔéʔləŋ (Sngequ House) building (and potentially other new buildings with abnormal characters) display incorrect location names since the new characters haven't been added to the available character library. Instead the result displays as "Sŋéqə ʔéʔləŋ | Sngequ House 133." This can be seen on both the individual class' page as well as the timetable tab, as shown in the screenshots section below.

To Reproduce

Steps to reproduce the behaviour/bug/issue:

  1. Search for ECE470 in the class search
  2. Click on the Class page to view result in class page
  3. Click "add to timetable"
  4. Click on the timetable tab to view result in timetable

Expected Behaviour

On the Class page the correct spelling of the building should appear, as well as the room name (which already does so this is not an issue). On the timetable tab the room name should appear with the building abbreviation (unsure what the proper abbr. is though, however classroom is not visible at the moment).

Screenshots

Class page (note the location tab): image

Timetable tab (note the other courses have visible room locations whereas the ECE470 class is not legible): image

Desktop/Mobile

Additional Context

Note: UVIC's official page for the building is here: https://www.uvic.ca/search/maps-buildings/buildings/sngequ-house.php

These are the characters UVIC uses in their publication/webpage: image

JC-02 commented 6 months ago

I will note that this looks like something similar was addressed in pull request here: https://github.com/VikeLabs/courseup/pull/497