Subtitle rendering

[codecov[bot]]

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered :open_umbrella:

[NaveenRagunathan]

Hi @elysoly can you elaborate on this subtitle rendering issue?

[elysoly]

Hi @elysoly can you elaborate on this subtitle rendering issue?

Hello @NaveenRagunathan :) I made an issue about it: issue 123. Overall it is working with this PR, the only issue is that the duration of the video with subtitles is a few milliseconds longer than the original one. For example, the original video is 15.05 sec long, while the subtitled version is 15.08 sec. I think the problem is coming from ffmpeg parameters, because when I just rewrite the original video (without subtitles and audio), I still have the same problem. We can modify ffmpeg parameters:

 final_video.write_videofile(
            output_video_path,
            fps=video.fps,
            codec=self.codec,
            audio_codec="aac",
            ffmpeg_params="",
        )

[elysoly]

tests/test_postprocessing.py::TestPostProcessing::test_render_subtitle does not pass for me, though it passed with CI but CI does not ship all our local integration tests. Could you check from a fresh venv?

It passes for me. What is the error you get?

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud