search

Vikranth3140 / Encryption-Decryption-Tool

This Python tool provides a flexible way to encrypt and decrypt files using Stored Key Method and Password-Based Key Derivation.
MIT License
4 stars 5 forks source link

Frontend Integration and Function Enhancements #10

Closed Anshu370 closed 1 month ago

Anshu370 commented 1 month ago

~Frontend completed and successfully connected with script.py. ~Modified the encrypt_file and decrypt_file functions to handle both GUI and CLI functionality for smoother user experience. ~Ensured compatibility between the two interfaces. ->Requirements ~pip install customtkinter Images Screenshot 2024-10-18 190051

Vikranth3140 commented 1 month ago

Hey @Anshu370, Thanks for sending a PR for this #7 issue.

Please check the reviews i have left and also please test the application and send me a clip if possible. I do not think the password matching is robust and correctly implemented as of now.

Anshu370 commented 1 month ago

Hey @Vikranth3140, This PR for #7 is completed.

I had fixed all the issues and test them here is the clip for the same. I have recorder both the Scenario before and after of the code correction.

https://github.com/user-attachments/assets/a46810b1-69eb-4233-a4f6-902f451cb66e

Vikranth3140 commented 1 month ago

Hey @Anshu370,

Thanks for the changes, I have reviewed the changes and it looks good to go.

A couple of changes requested for enhancement.

  1. Increase the size of the password dialogue box.
  2. Make sure the secret.key is initialized in the root directory and in the FrontEnd directory.
  3. Sync the changes back to the original repo to resolve merge conflicts.
  4. Run pre commit on the codebase

After this we are good to go for your First Accepted PR!

Anshu370 commented 1 month ago

okay