search

ViktorArtemiev / Surveys

Nimble Technical Test
0 stars 0 forks source link

Requesting for more testing coverage #3

Closed sleepylee closed 5 years ago

sleepylee commented 5 years ago

We'd like to see further testing coverage from your side, given that testing is never enough nor a guarantee to a quality application, but we still prefer to see how further can you push with your current architecture, that leveraging Dagger, ViewModel...etc..

nhphong commented 5 years ago

@ViktorArtemiev Any update on this issue? How about an instrumented test with Espresso and Dagger being set up (to inject mock object)?

ViktorArtemiev commented 5 years ago

Hello @nhphong MainViewModel has been already covered by Unit tests. You can check it out in this commit https://github.com/ViktorArtemiev/Surveys/pull/19/commits/78756d47731df260e3260aabeed2199334c30914

The next step will be to write the instrumented test for MainActivity leveraging Espresso and Dagger. The task is expected to be completed by tomorrow.

ViktorArtemiev commented 5 years ago

Hi @nhphong MainActivity has been covered by instrumentation tests. Tests can be checked out in this commit f70e122ed6c995d0ec70396b5c37ed8c808c5630

PR linked #19