Few minor suggestion for more kotlin flavor

ViktorArtemiev / Surveys

Nimble Technical Test

0 stars 0 forks source link

Closed sleepylee closed 5 years ago

sleepylee commented 5 years ago

Scoping functions like .run() or .apply()...can be used for these cases where you can improve the readability of the codes.
this@MainActivity is a bit redundant imo, since the scope is not overlapped anywhere it calls, but I'm kind of understand your clarity preference 😇

sleepylee commented 5 years ago

Also,

If we just need a similar form of publish static final String like the good old java style, instead of creating a companion object just to hold such things like here, how about keeping them as const on the top class level?

ViktorArtemiev commented 5 years ago

Hello @sleepylee Trung

Code readability improved.

Pull-request linked #13