Activity (View) is still holding a bit many logics to its side.

ViktorArtemiev / Surveys

Nimble Technical Test

0 stars 0 forks source link

Activity (View) is still holding a bit many logics to its side. #7

Closed sleepylee closed 5 years ago

sleepylee commented 5 years ago

I saw from here that the View is holding a piece of UI changes where it doesn't know when the next state occurs isVisible = true. It might sound a bit nitpicking, but when refresh() shouldn't the ViewModel emit the loading state (similar) and let the View know as an observer as well? At least for the consistency in your idea of how we handle the loading state.

ViktorArtemiev commented 5 years ago

Hello @sleepylee Trung

You are right it's better to handle this loading state via the observer in this case Thank you!

pull-request linked #15