search

ViktorJp / RTRMON

Asus-Merlin Router Health/Performance Monitor
GNU General Public License v3.0
17 stars 1 forks source link

Fix Page 7 Info #16

Closed ExtremeFiretop closed 3 months ago

ExtremeFiretop commented 3 months ago

Fix Page 7 Information

ViktorJp commented 3 months ago

@ExtremeFiretop -- I really appreciate your hard work on this!! So when I tested this out on my end, it seems to prefer whatever is in my dnsmasq than what custom names were given in the client names NVRAM entry... as shown below...

image

And I still think this might be because it's prematurely break-ing with that new break that was added, instead of allowing it to loop through the client names NVRAM entry until it matches a MAC address... which then gives me this (when that break is removed and looping is back on -- but caused an endless loop for you)

image

For some reason... the LAN section isn't resolving my preferred names any longer, and need to look into further.

ExtremeFiretop commented 3 months ago

Hey @ViktorJp

I've fixed the first issue of the endless loop for me and not being able to reach the right device for you (I only had the one device in the nvram so naturally it would always either pass on the first try or fail completely)

The LAN is populating for me now, that was a different issue.

Now the only outstanding is:

  1. Missing names on VLAN
  2. Missing IP and Name on Guest WiFi?

Those two might need some relogic since in my case, they are both trying to display the same info essentially.

ExtremeFiretop commented 3 months ago

I think I fixed the VLANs as well :) Works for me!

ExtremeFiretop commented 3 months ago

That's it.

I'm done and this is ready for merge when you are @ViktorJp :)

ViktorJp commented 3 months ago

Amazing work, @ExtremeFiretop! Thank you very much for your talents in helping get this working right in a 3006 environment! :)