Score file is written out without expanding/interpolating environment variable

Viladoman / CompileScore

Tools for profiling and visualizing C++ build times.

MIT License

464 stars 19 forks source link

Score file is written out without expanding/interpolating environment variable #24

Open missmah opened 2 years ago

missmah commented 2 years ago

Actually, to be specific, it seems like it's expanding it and then adding it to the path unexpanded!

missmah commented 2 years ago

(I also ended up having to specify an absolute path for my custom file to get it read properly)

Viladoman commented 2 years ago

Sadly, at this point of time, the macros supported are limited and hardcoded

I will can have a look and try to update this so it can borrow a more extensive macro list.

missmah commented 2 years ago

Ah, thanks for the references to the code and documentation, very helpful!

Seems like I could hard-code ours in a fork :-)

Maybe one day if I get time, I can add a PR to query and support all of them dynamically?

galop1n commented 2 years ago

I second the interest into expansion of all env variable and not the existing limited set ! Also, a bug currently in the implementation on opening a solution, the compile score tab resolve a $(Platform) macro as "x64", while in our case, the platform is actually "somethingelse". If I change the active platform to an other and back, the macro is resolved to "somethingelse" properly again