Viladoman / CompileScore

Tools for profiling and visualizing C++ build times.
MIT License
460 stars 19 forks source link

Two header with the same filename are considered being the same file in include view #36

Open Dragnalith opened 1 year ago

Dragnalith commented 1 year ago

Hello, I have noticed a problem: when 2 headers have the same filename they are consider to be the same file. For instance all the stdafx.h of my project are shown as one file in the include graph. Another example it happens for time.h which can be the libc one or the one in my project (including as #include <MyProject/Time.h>)

PS: Compile Score is incredible, thank you!

Viladoman commented 1 year ago

Hi! I am glad this project has been helpful so far.

I have good news and bad news at the same time regarding this issue. If you are profiling MSVC this issue should be resolved on version v1.7.0 as it will use the full path to know if 2 includes point to the same file or not. Sadly, Clang outputs the data with relative paths next to the object files which makes tricky to reconstruct the actual full path.

Version 1.7.0 can be found in this repo but I have not pushed it to the marketplace yet as I need to find a solution for this and other new issues with the Clang extractor,

I hope this helps.

Dragnalith commented 1 year ago

Hi,

Thank you for your reply.

Actually I do use the version 1.7.0, I downloaded on github, but header file with same filename are still considered to be the same file.

Regards

On Sat, Sep 24, 2022, 05:49 Ramon Viladomat @.***> wrote:

Hi! I am glad this project has been helpful so far.

I have good news and bad news at the same time regarding this issue. If you are profiling MSVC this issue should be resolved on version v1.7.0 as it will use the full path to know if 2 includes point to the same file or not. Sadly, Clang outputs the data with relative paths next to the object files which makes tricky to reconstruct the actual full path.

Version 1.7.0 can be found in this repo https://github.com/Viladoman/CompileScore/releases/tag/v1.7.0 but I have not pushed it to the marketplace yet as I need to find a solution for this and other new issues with the Clang extractor,

I hope this helps.

— Reply to this email directly, view it on GitHub https://github.com/Viladoman/CompileScore/issues/36#issuecomment-1256660065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHSSFCSCDPVXZSPHPYWX2DV7YJXFANCNFSM6AAAAAAQTTBG7U . You are receiving this because you authored the thread.Message ID: @.***>