Viladoman / CompileScore

Tools for profiling and visualizing C++ build times.
MIT License
460 stars 19 forks source link

convert to SDK-style projects #38

Closed Trass3r closed 1 year ago

Trass3r commented 1 year ago

It's a first step towards cross-platform. If you try a different framework on top (upgrade-assistant upgrade .\CompileScore.sln) it chokes on the WinForms stuff though.

diff --git a/CompileScore/WPF/CompileScoreWPF.csproj b/CompileScore/WPF/CompileScoreWPF.csproj
index 299fd69..75248bb 100644
--- a/CompileScore/WPF/CompileScoreWPF.csproj
+++ b/CompileScore/WPF/CompileScoreWPF.csproj
@@ -3,7 +3,7 @@
     <OutputType>WinExe</OutputType>
     <RootNamespace>CompileScore</RootNamespace>
     <AssemblyName>CompileScore</AssemblyName>
-    <TargetFramework>net472</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
     <ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <AssemblyTitle>CompileScore</AssemblyTitle>
@@ -128,4 +128,10 @@
   <ItemGroup>
     <Resource Include="CompileScore.ico" />
   </ItemGroup>
+  <ItemGroup>
+    <PackageReference Include="Microsoft.DotNet.UpgradeAssistant.Extensions.Default.Analyzers" Version="0.4.346202">
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
+    <PackageReference Include="Microsoft.Windows.Compatibility" Version="6.0.0" />
+  </ItemGroup>
 </Project>
\ No newline at end of file
Viladoman commented 1 year ago

My knowledge on C# configurations is quite limited tbh. Thanks for your help and contribution. Super appreciated!!

Viladoman commented 1 year ago

I checked the changes locally, and it looks like the Visual Extension projects are no longer generating the vsix files.

3>CompileScoreVS17 -> C:\Users\ramon\Documents\Code\See\CompileScore\CompileScore\VSIX17\bin\Debug\net472\CompileScore.dll
1>CompileScoreVS16 -> C:\Users\ramon\Documents\Code\See\CompileScore\CompileScore\VSIX16\bin\Debug\net472\CompileScore.dll

image

I reverted back the the CompileScoreVS16 and VS17 'csproj' so we are still generating the extensions.