fix: GatherSolutionConfiguration() null derefs ConfigurationManager

Viladoman / CompileScore

Tools for profiling and visualizing C++ build times.

MIT License

460 stars 19 forks source link

Closed ikrima closed 3 years ago

ikrima commented 3 years ago

added guard check against it
needs logic check: I verified that SetConfiguration/SetPlatform get called appropriately anyway during solution open but didn't dig too deep in the global extension flow logic
cursory view on vs forms indicate it might be a VS bug but could possibly be GatheredSolutionConfiguration() is called too early

Viladoman commented 3 years ago

Thanks! :) I will double check the flow there. Was there anything special on the solution or how it was opened?

ikrima commented 3 years ago

Nothing special afaik. It trigger the deref everytime (tried opening from explorer, vstudio start page, and file->open solution)

Thought possibly something wrong with my vs install but tried opening it in the clean experimental instance and it still triggered

Viladoman commented 3 years ago

I have never had it during any of my tests. If it crashes it is worth updating the published version.