search

Villen-Lab / pyAscore

A python package for fast post translational modification localization, powered by Cython.
https://pyascore.readthedocs.io/
MIT License
18 stars 5 forks source link

Compiling with mac #46

Closed freejstone closed 1 year ago

freejstone commented 1 year ago

Hi there!

I have been trying to embed pyAscore with a tool that I have recently created to localize peptide-identifications. I just wanted to flag that I had some issues trying to install it for my mac computers (both M1 and intel-based). I was successfully able to install it by changing the c++ compiler from clang to g++ homebrew, and specifying in the setup.py file extra_compile_args=['-std=c++11']. I am not very familiar with Cython and C/C++ generally, so I am not sure if this is the best solution.

Cheers,

Jack

AnthonyOfSeattle commented 1 year ago

Great to hear this is getting used. Also I am glad to hear that you found something that worked. I was relatively inexperienced with Macs when I built this so and haven't gotten a chance to come back.

If you have something that works, and have the bandwidth, feel free to put in a PR for a GitHub action which builds and pushes the Mac version of the package to PIP.

Otherwise, I will try and incorporate your advice soon.

freejstone commented 1 year ago

No problem. I'll first attempt to embed it into the tool I am using and if I beat you to it I'll put in a PR

Cheers,

Jack

freejstone commented 1 year ago

Okay created a PR just now.

Cheers,

Jack

freejstone commented 1 year ago

Closing now, thanks Anthony!