Villen-Lab / pyAscore

A python package for fast post translational modification localization, powered by Cython.
https://pyascore.readthedocs.io/
MIT License
18 stars 5 forks source link

unittest errors relating to pyteomics #47

Closed freejstone closed 1 year ago

freejstone commented 1 year ago

Hi me again!

Whilst I don't think there is any problems with your module, I wanted to flag some some issues that occurred when running the unittests. I think there might be a small bug in the pyteomics package which I made an issue there. The errors are attached in the text file. After fixing the small bug in the pyteomics package, things work however I come across one last error. Are you able to reproduce these errors that are triggered by the pyteomics package?

unitttest-errors.txt

Cheers,

Jack

freejstone commented 1 year ago

As part of the recent PR that I submitted, I had made a fix for this. See the related issue on pyteomics: https://github.com/levitsky/pyteomics/issues/110

Cheers,

Jack

freejstone commented 1 year ago

Closing now, thanks Anthony!