search

Villhellm / lovelace-animated-background

Animated backgrounds for lovelace
195 stars 61 forks source link

view specific backgrounds broken? #13

Closed Fredfishface closed 4 years ago

Fredfishface commented 4 years ago

Hi, Great addon. Your default example (animated backgrounds for all views) works. If I add a view option for a specific path I get the same background for all views. If I add two view specific options, I don't get anything.

Windows 10, chrome, latest version of home assistant.

Doesn't Work: animated_background: views:

Works: animated_background: default_url: /local/animated-background/background-animations/sunny.html included_users:

Doesn't Work: animated_background: default_url: /community_plugin/lovelace-animated-background/background-animations/sunny.html included_users:

Villhellm commented 4 years ago

That is not valid YAML. Please post your configs in code blocks with proper formatting. Also if you have the lines

included_users:
  - Villhellm

the config shouldn't work unless the home assistant user you are logged in as is Villhellm.

Fredfishface commented 4 years ago

Leaving in Villhellm would have been a total doofus move :-). Home Assistant 0.108.6 Frontend version: 20200407.2 - latest

Doesn't work (no backgrounds for any paths):

animated_background: views:

Works (all path backgrounds are sunny):

animated_background: default_url: /community_plugin/lovelace-animated-background/background-animations/sunny.html

Doesn't Work (all backgrounds are sunny, view path is also sunny - not fog - can be any existing path):

animated_background: default_url: /community_plugin/lovelace-animated-background/background-animations/sunny.html views:

Fredfishface commented 4 years ago

When I submit, the yaml collapses. All of it is correctly formatted. If there is a trick to entering it here, please let me know.

Villhellm commented 4 years ago

You need to put code in code blocks. Surround the yaml with ``` on the line above and bellow Ex: ``` animated_config: default_url: /test ``` becomes

animated_config:
  default_url: /test
Villhellm commented 4 years ago

0.108.6 is not the latest, by the way. Remember it is important to always give actual version numbers as "latest" changes regularly.

Fredfishface commented 4 years ago

Thank you.

Home Assistant 0.109.2 Frontend version: 20200427.1 - latest

Does not work:

animated_background:
views:
- path: alarm
config:
default_url: /community_plugin/lovelace-animated-background/background-animations/fog.html

Does Work:

animated_background:
default_url: /community_plugin/lovelace-animated-background/background-animations/sunny.html

Does not Work:

animated_background:
default_url: /community_plugin/lovelace-animated-background/background-animations/sunny.html
views:
- path: alarm
config:
default_url: /community_plugin/lovelace-animated-background/background-animations/fog.html
Fredfishface commented 4 years ago

I placed the yaml within ```. I'll find another background solution.

Villhellm commented 4 years ago

This is not me being pedantic, spaces are critical in yaml. If I can't see an accurate config I can't accurately tell you what's wrong.

Are you seeing any errors in the browser console?

Fredfishface commented 4 years ago

I didn't believe you were.

No, the console log shows that the default animated background is loaded (which it is).

Villhellm commented 4 years ago

The only other thing I could think to check without more information is make sure that your path is an exact match.

Fredfishface commented 4 years ago

kk. I'll put some debug lines in the js and see where I end up. Thanks.

Villhellm commented 4 years ago

You can also set breakpoints in Chrome and follow it through each step

Villhellm commented 4 years ago

When I test your two "Does not work" configs and properly format the yaml it works on my machine. Be sure to update the plugin as well, I fixed a bug recently that may have been affecting one of those configs.

Fredfishface commented 4 years ago

Hi,

Thanks for that. I found:

Error handling response: TypeError: Cannot read property 'enumerateDevices' of night.html:1 undefined

at get_devices (chrome-extension://gfhcppdamigjkficnjnhmnljljhagaha/content.js:119:25)

at chrome-extension://gfhcppdamigjkficnjnhmnljljhagaha/content.js:100:5

Let you know.

J

From: Villhellm notifications@github.com Sent: May 1, 2020 11:47 AM To: Villhellm/lovelace-animated-background lovelace-animated-background@noreply.github.com Cc: Fredfishface info@goodenuf.ca; Author author@noreply.github.com Subject: Re: [Villhellm/lovelace-animated-background] view specific backgrounds broken? (#13)

When I test your two "Does not work" configs and properly format the yaml it works on my machine. Be sure to update the plugin as well, I fixed a bug recently that may have been affecting one of those configs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Villhellm/lovelace-animated-background/issues/13#issuecomment-622513068 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEPRZZLUSEHPGLKGD3FBQ3RPMKKZANCNFSM4MWWKFMA .

Villhellm commented 4 years ago

Can you try to post your config one more time? Maybe a screenshot if you can't get the formatting to work?

Fredfishface commented 4 years ago

Hi, I believe I managed to post the correctly formated yaml from the raw config editor for the dashboard in https://community.home-assistant.io/t/lovelace-animated-background-based-on-entity-state/132208/36 Apologize for the delay. Work beckoned.

Villhellm commented 4 years ago

Your path: line is not properly indented. It needs to be on the same level as config:

Fredfishface commented 4 years ago

Call me doofus. I'd love to tell you that it still doesn't work but it is fixed :-). Many thanks. In addition I now know how to make custom cards.