fix(#38): cannot make commit after project initialization

[paaneko]

Description

Fix issues that prevent developers from making commits if they don't have PHP installed on their local machines.

Related Issue

resolves #38

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [x] I have performed a self-review of my code.
• [ ] I have commented my code, particularly in hard-to-understand areas.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING.md document.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.
• [x] You have only one commit (if not, squash them into one commit).

[paaneko]

Because there is no php container running inside the php container, so make commands from the Makefile cannot be run inside the container. In the commit I hardcoded the commands from Makefile and it doesn't look very cool. Maybe someone knows how to make it more flexible?

[Kravalg]

You need to run the application using the make start command and then commit and push your changes

[paaneko]

Done. But can u please explain why i should run make start before pushing? Very interesting)

[Kravalg]

Because we run all CI checks in the one environment - docker container with the php Make start will run the php container, then you can develop a new feature or fix the bug, test it, run locally all CI checks that you need, and then commit and push changes, which will be tested by captainhook in the same container where you did the changes

[Kravalg]

@paaneko can we close this PR ?

[paaneko]

Yes, on mac this issue fixed.

[paaneko]

Oh, I didn’t notice that the commits with my changes were not merged into main, so the problem remains. Problem is that the captainhook uses PHP installed on the local machine, and not Docker one. And my changes fix it. Even if i run make start command, captainhook will throw error in console that php not found on local machine.

[paaneko]

We little misunderstood each other :)

[Kravalg]

Please check the Makefile, we are using the docker compose by default for make commands that we are running in the captainhook @Derane can you check this bug additionally ?

[paaneko]

It can't be done because CaptainHook will call make commands inside the Docker container, and it requires another Docker container inside container for make commands. Unfortunately, this container does not exist.

Possible solution would be to create a Docker-in-Docker image, which the first container CaptainHook will use to run built-in commands and captainhook scripts that require PHP dependency. For example:

"actions": [
    {
        "action": "\\CaptainHook\\App\\Hook\\Message\\Action\\Regex",
        "options": {
            "regex": "/^(feat|fix|refactor|build|chore|ci|doc|style|perf|test)\\(\\#\\d+\\):.*$/i",
            "error": "The commit message should be in the format: feat|fix|refactor|build|chore|ci|doc|style|perf|test(#1):"
        }
    }
]

However, to call make commands, it needs a nested php container inside the first php container.

The solution I provide in this PR is to run check commands without the docker compose exec php prefix, so the command will run on the first Docker container without requiring nested one.

[Kravalg]

Thanks a lot, @Derane will check this bug

[Derane]

Thanks a lot, @Derane will check this bug

Yeah, @paaneko is right. PHP installed locally really must have for commit.