VilnaCRM-Org / user-service

Creative Commons Zero v1.0 Universal
5 stars 1 forks source link

Proposal: increase `phpinsights` line length limit to 80+ characters #44

Open paaneko opened 1 month ago

paaneko commented 1 month ago

The current line length limit is very annoying during development. It forces me to cut class names, which decreases the quality of the context that can be read from the class name. And also forces spend time on refactoring code under phpinsights requirements instead of developing new features.

Sometimes it leads to issues that cannot be resolved by refactoring code and often require adding files to the exclude list.

This not only looks ugly but also decreases code readability and increases function line height. For example:

$this->confirmationTokenFactory = 
            $this->createMock(ConfirmationTokenFactoryInterface::class);

$this->confirmationTokenFactory = $this->createMock(
            ConfirmationTokenFactoryInterface::class
        );

The PSR-12 standard doesn't impose a hard limit on line length, but it recommends a soft limit of 120 characters, and to keep lines under 80 characters where possible.

I begging your team to reconsider this length limit rule and increase it to at least 100 characters.