search

Vimux / Binario

Responsive card-based & code-light Hugo theme
https://binario.netlify.app
MIT License
116 stars 53 forks source link

add spotify social #67

Open twobiers opened 2 years ago

twobiers commented 2 years ago

I made this addition for myself, maybe you are also intersted in it.

Vimux commented 2 years ago

We have strict criteria for the icons we distribute. In addition to the formal requirements from our guidelines, there are also informal ones: small size matters. Look at the chart below and find your icon.

Spot the Imposter

I know it's not very fashionable to count bytes on icons on the modern web, but it still matters to me. One kilobyte here, another kilobyte there, and now only icons weigh a lot. This task is more time-consuming than it looks at first.

twobiers commented 2 years ago

We have strict criteria for the icons we distribute.

If you've added or modify SVG, ensure that each SVG file:

  • Be less than 2048 bytes

From your CONTRIBUTING document. Is it outdated?

However, I got your point agree with that. I could reduce the file size to 713 Bytes. However, I'm not an expert in SVGs, there might be more potential for compression.

Vimux commented 2 years ago

From your CONTRIBUTING document. Is it outdated?

Nope, still valid. Icons can be complex, so we need an extra size margin. In general, I don't review larger icons. It's a start, not a finish.