search

VinF / deer

DEEp Reinforcement learning framework
Other
485 stars 126 forks source link

AC_net_keras qnetwork.getAllParams() #50

Closed dynamik1703 closed 7 years ago

dynamik1703 commented 7 years ago

Hey VinF, thank you very much for your great work! I'm enjoying to use deer a lot.

I would like to save trained ACNetworks.

But when I'm training a ACNetwork for example with run_mountain_car_continuous.py it's for me not possible to get (and save) the network parameters.

qnetwork.getAllParams() -> AttributeError: 'Variable' object has no attribute 'get_value'

How can I save a network?

Thank for your help!

VinF commented 7 years ago

Hi, Thanks for the feedback. The issue should be fixed!

dynamik1703 commented 7 years ago

Hi VinF, thank you for the quick fix! Well done.

I have just two points. When I'm trying to update deer with pip it tells me I have the newest version.

In "def setAllParams(self, list_of_values):" the print command is without parentheses. For using it in Python 3 it would be advantageous to add them: print i (116) and print i+j (118).

Thanks

VinF commented 7 years ago

Yep, indeed... I just forgot to remove the prints (fixed now)

I have also updated the version on pip to 0.3.1

Thanks