search

Vinai / VinaiKopp_EavOptionSetup

Magento2 extension to easily add EAV attribute options to attributes only if the option doesn't exist yet.
21 stars 5 forks source link

Expand support to more Magento versions #5

Closed hostep closed 3 years ago

hostep commented 3 years ago

Previously the magento/module-eav constraint only allowed the versions included in Magento 2.0 and 2.1 Allowing major versions 101 and 102 now allows the module to also be installed on Magento 2.2, 2.3 and 2.4

Watch out: I didn't actually test the module functionality-wise on newer Magento versions, although I was able to execute bin/magento setup:di:compile without issues on Magento 2.3.6, but that's not a full test 🙂

I've also cleaned up the php version constraint, it was unnecessarily complex, ^7.0.0 already accepts 7.0.0 to 7.9999.9999. I also quickly tested with https://github.com/fortrabbit/phpco-docker and that tool doesn't discover problems with PHP 7.0, 7.1, 7.2, 7.3 and 7.4

Vinai commented 3 years ago

Thank you!