Tries to generate paths longer than the system can handle

Vinai / nicer-image-names

Magento extension to build catalog image file names from product attributes so they have neat descriptive names.

77 stars 31 forks source link

Tries to generate paths longer than the system can handle #14

Closed mikemanger closed 10 years ago

mikemanger commented 10 years ago

The generated image paths can be longer than the file system can handle which causes the image not not get rendered. Most systems support 255 bytes for the filename and 4096 for the path. NTFS (Windows) only supports 255 for the whole file path!

This is not a huge problem as I can tell the client to not put so much text in the meta_title (or just use a different attribute instead).

mikemanger commented 10 years ago

If this is worth fixing, the two solutions I can think of:

Crop the file name down until it fits
- But not sure on the best way to find what the system's max length is - PHP 5.3 has PHP_MAXPATHLEN
- This could result in some 'bad' filenames if cropped in an inconvenient place (e.g. cropping mid sente
check if the generated file path is OK (if not, use the original cached file).
- file_exists() or I think realpath() will return false

Vinai commented 10 years ago

Thanks for the useful info! Future releases will include your suggestions to check the path length.