search

Vinai / nicer-image-names

Magento extension to build catalog image file names from product attributes so they have neat descriptive names.
77 stars 31 forks source link

Problem with accents #16

Closed d4n13l3 closed 10 years ago

d4n13l3 commented 10 years ago

When an accented character exist within the productn name, the image url points at the accented word, while the image file is renamed using HTML entities.

Example: %name-%sku

URL: borsa-franzy-leghilà-44-franzyl Image name: borsa-franzy-leghilà-44-franzyl

Vinai commented 10 years ago

The test runns smoothly, changing à to a for file names. For labels (aka alt="à") it doesn't change it. Here are the testcases: https://github.com/Vinai/nicer-image-names/blob/master/app/code/community/Netzarbeiter/NicerImageNames/Test/Helper/ImageTest.php#L48

Which version of the extension are you using? And which version of Magento?

d4n13l3 commented 10 years ago

Magento 1.8.0.0 Extension 0.2.3 (beta)

But it seems it was Magento's fault in renaming stuff. I manually edited all the entries (product name, url and manufacturer attribute) and now it's working properly.

My bad, sorry!

Vinai commented 10 years ago

Thats strange! How did Magento rename things? Do values with accented characters now work for you?

d4n13l3 commented 10 years ago

I had product names with html entities in them, it's strange i know =S Now everything is working properly, thanks for your time!

2014-02-18 23:24 GMT+01:00 Vinai Kopp notifications@github.com:

Thats strange! How did Magento rename things? Do values with accented characters now work for you?

Reply to this email directly or view it on GitHubhttps://github.com/Vinai/nicer-image-names/issues/16#issuecomment-35442736 .