search

Vinai / nicer-image-names

Magento extension to build catalog image file names from product attributes so they have neat descriptive names.
77 stars 31 forks source link

Added + to the prepare value array, in order to get it replaced #40

Closed dverkade closed 6 years ago

dverkade commented 7 years ago

When there is a plus in an attribute which is used to compile the filename, I got a filename like:

-katoen-kreta-blue-dreamcatcher-kreta-blue-dekbedovertrek-240x200-220-+-2-x-60x70-overtrekset-vndck-20.jpg

The result was the following filename:

-katoen-kreta-blue-dreamcatcher-kreta-blue-dekbedovertrek-240x200-220-%20-2-x-60x70-overtrekset-vndck-20.jpg

This resulted in a 404 message for this image. Added the + char to the special characters in order to resolve this.

dverkade commented 6 years ago

@Vinai want to have a look at this PR and accept it, or close it? It's open for over a year.

Vinai commented 6 years ago

Hey @dverkade, sorry - I missed the notification! Merged!